Replace connect with useSelector() and useDispatch() 3/5 #2316 #2341
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
==========================================
+ Coverage 94.40% 94.42% +0.01%
==========================================
Files 1167 1168 +1
Lines 24957 24985 +28
Branches 5303 5304 +1
==========================================
+ Hits 23561 23591 +30
+ Misses 1329 1327 -2
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ahtesham-quraish
changed the title
There was a problem hiding this comment.
Thanks for this!
For reviewers, please don't merge this until we've merged #2343 and rebased this on top of it. I suggest holding off on review until then as well.
| const intl = useIntl(); | ||
| const { editorRef, refReady, setEditorRef } = prepareEditorRef(); | ||
|
|
||
| // Select state values using useSelector |
|
@ahtesham-quraish Could you please take another look at this PR, and rebase it etc.? I'd appreciate if you can help get all your PRs green and ready for review, and address all outstanding comments before opening any more new PRs. I'll try to help with your coverage questions where I can, but I'm a little behind in my reviews at the moment. Thanks! |
| import React from 'react'; | ||
| import { Provider } from 'react-redux'; | ||
| import { render as baseRender } from '../testUtils'; | ||
| import { EditorContextProvider } from './EditorContext'; | ||
| import { initializeStore } from './data/redux'; // adjust path if needed | ||
|
|
||
| /** | ||
| * Custom render function for testing React components with the editor context and Redux store. | ||
| * | ||
| * Wraps the provided UI in both the EditorContextProvider and Redux Provider, | ||
| * ensuring that components under test have access to the necessary context and store. | ||
| * | ||
| * @param {React.ReactElement} ui - The React element to render. | ||
| * @param {object} [options] - Optional parameters. | ||
| * @param {object} [options.initialState] - Optional initial state for the store. | ||
| * @param {string} [options.learningContextId] - Optional learning context ID. | ||
| * @returns {RenderResult} The result of the render, as returned by RTL render. | ||
| */ | ||
| const editorRender = ( | ||
| ui, | ||
| { | ||
| initialState = {}, | ||
| learningContextId = 'course-v1:Org+COURSE+RUN', | ||
| } = {}, | ||
| ) => { | ||
| const store = initializeStore(initialState); | ||
|
|
||
| return baseRender(ui, { | ||
| extraWrapper: ({ children }) => ( | ||
| <EditorContextProvider learningContextId={learningContextId}> | ||
| <Provider store={store}> | ||
| {children} | ||
| </Provider> | ||
| </EditorContextProvider> | ||
| ), | ||
| }); | ||
| }; | ||
|
|
||
| export default editorRender; |
There was a problem hiding this comment.
Please remove this file and just use the existing editorRender function. Generally, this PR has the same issues as #2346 which I just reviewed too.
Description
#2316.
Supporting information
Link to other information about the change, such as GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for manually testing this change.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'